]> git.ipfire.org Git - thirdparty/qemu.git/commit
hvf: arm: Add permission check in GIC sysreg handlers
authorZenghui Yu <zenghui.yu@linux.dev>
Mon, 14 Jul 2025 16:01:38 +0000 (00:01 +0800)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 21 Jul 2025 10:19:56 +0000 (11:19 +0100)
commitf19310b23a00b5c19f930e4d57fc298744d11740
treeef4d383228899a45ca93fa21cffc3164a8090a48
parent082933a1f7d3c8e4a9e999c3d284928ef866c67d
hvf: arm: Add permission check in GIC sysreg handlers

Quoting Peter Maydell:

" hvf_sysreg_read_cp() and hvf_sysreg_write_cp() do not check the .access
  field of the ARMCPRegInfo to ensure that they forbid writes to registers
  that are marked with a .access field that says they're read-only (and
  ditto reads to write-only registers). "

Before we add more registers in GIC sysreg handlers, let's get it correct
by adding the .access checks to hvf_sysreg_read_cp() and
hvf_sysreg_write_cp(). With that, a sysreg access with invalid permission
will result in an UNDEFINED exception.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Zenghui Yu <zenghui.yu@linux.dev>
Message-id: 20250714160139.10404-2-zenghui.yu@linux.dev
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/hvf/hvf.c