]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
coresight: tmc: Fix overflow when calculating is bigger than 2GiB
authorLeo Yan <leo.yan@arm.com>
Tue, 17 Feb 2026 13:19:43 +0000 (13:19 +0000)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 7 May 2026 13:40:03 +0000 (14:40 +0100)
commitf195d54deef1bc6dd3326394975baff02c7ae487
tree5db527dea0df768ba4e04ceed2c732a0ae0b0b3a
parent551bb2fd5e4ed63d33aa11f07102cce5179b7595
coresight: tmc: Fix overflow when calculating is bigger than 2GiB

When specifying a 2GB AUX buffer, the ETR driver ends up allocating only
a 1MB buffer instead:

  # echo 'file coresight-tmc-etr.c +p' > \
/sys/kernel/debug/dynamic_debug/control
  # perf record -e cs_etm/@tmc_etr0,timestamp=0/u -C 0 -m ,2G -- test
  coresight tmc_etr0: allocated buffer of size 1024KB in mode 0

The page index is an 'int' type, and shifting it by PAGE_SHIFT overflows
when the resulting value exceeds 2GB.  This produces a negative value,
causing the driver to fall back to the minimum buffer size (1MB).

Cast the page index to a wider type to accommodate large buffer sizes.
Also fix a similar issue in the buffer offset calculation.

Reported-by: Michiel van Tol <michiel.vantol@arm.com>
Fixes: 99443ea19e8b ("coresight: Add generic TMC sg table framework")
Fixes: eebe8dbd8630 ("coresight: tmc: Decouple the perf buffer allocation from sysfs mode")
Signed-off-by: Leo Yan <leo.yan@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20260217-arm_coresight_fix_big_buffer_size-v1-1-774e893d8e3f@arm.com
drivers/hwtracing/coresight/coresight-tmc-etr.c