]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: logitech-dj: Remove duplicate error logging
authorHans de Goede <johannes.goede@oss.qualcomm.com>
Sat, 8 Nov 2025 21:03:18 +0000 (22:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:40 +0000 (10:14 +0100)
commitf1d629bda89de1a56ffe8ec77b62dd42de024e7b
tree9449f0ce96dd160f30ffe098cfe431599f6b0a6b
parentc2c3f1a3fd74ef16cf115f0c558616a13a8471b4
HID: logitech-dj: Remove duplicate error logging

commit ca389a55d8b2d86a817433bf82e0602b68c4d541 upstream.

logi_dj_recv_query_paired_devices() and logi_dj_recv_switch_to_dj_mode()
both have 2 callers which all log an error if the function fails. Move
the error logging to inside these 2 functions to remove the duplicated
error logging in the callers.

While at it also move the logi_dj_recv_send_report() call error handling
in logi_dj_recv_switch_to_dj_mode() to directly after the call. That call
only fails if the report cannot be found and in that case it does nothing,
so the msleep() is not necessary on failures.

Fixes: 6f20d3261265 ("HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-logitech-dj.c