]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: bnx2fc: Fix skb double free in bnx2fc_rcv()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 14 Nov 2022 11:06:26 +0000 (11:06 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:13:32 +0000 (15:13 +0100)
commitf1d9a66e9ce9ff5d204cd4b787ca23771488a7dd
tree1894f0e1161984ca02f81a6735e764d07ab0bce7
parent1e3effe67e75d3339526dc23c9b7fa209040f373
scsi: bnx2fc: Fix skb double free in bnx2fc_rcv()

[ Upstream commit 08c94d80b2da481652fb633e79cbc41e9e326a91 ]

skb_share_check() already drops the reference to the skb when returning
NULL. Using kfree_skb() in the error handling path leads to an skb double
free.

Fix this by removing the variable tmp_skb, and return directly when
skb_share_check() returns NULL.

Fixes: 01a4cc4d0cd6 ("bnx2fc: do not add shared skbs to the fcoe_rx_list")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221114110626.526643-1-weiyongjun@huaweicloud.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c