]> git.ipfire.org Git - thirdparty/tor.git/commit
projects / thirdparty / tor.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bd7724a) | patch
Make base64_decode in rend_parse_client_keys more foolproof
authorNick Mathewson <nickm@torproject.org>
Thu, 19 Apr 2012 21:13:47 +0000 (17:13 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 19 Apr 2012 21:13:47 +0000 (17:13 -0400)
commitf2384d5e2c25469038caa84e0dedaa5e2efca29c
treea26859675d34bd09566dbab44fcd724ea0d8ec0etree | snapshot
parentbd7724a57eeb756232f5be222c643ccb8b364966commit | diff
Make base64_decode in rend_parse_client_keys more foolproof

In general, whenever we can, we should be doing
  base64_decode(buf, sizeof(buf), s, strlen(s)),
and not
  base_64_decode(buf, expr1, s, expr2)
where we hope that expr1 is a good name for the size of buf and expr2
is a good formula for the length of the base64 expression in s.
src/or/routerparse.c diff | blob | blame | history
Mirror of https://git.torproject.org/tor.git