git.ipfire.org Git - thirdparty/postgresql.git/commit

author	Amit Kapila <akapila@postgresql.org>
	Mon, 19 Jul 2021 05:45:03 +0000 (11:15 +0530)
committer	Amit Kapila <akapila@postgresql.org>
	Mon, 19 Jul 2021 05:45:03 +0000 (11:15 +0530)
commit	f2f459f182fc8b1af44e422e2324b7acd5ee2408
tree	a78ee3e79b66337ab7c6c0a5a51fe5944e3c601e	tree \| snapshot
parent	df12b625a6885cd200e580ebcc605209a16e17ad	commit \| diff

Don't allow to set replication slot_name as ''.

We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

src/backend/commands/subscriptioncmds.c		diff \| blob \| blame \| history
src/test/regress/expected/subscription.out		diff \| blob \| blame \| history
src/test/regress/sql/subscription.sql		diff \| blob \| blame \| history