]> git.ipfire.org Git - thirdparty/libvirt.git/commit
snapshot: ABI stability must include memory sizing
authorEric Blake <eblake@redhat.com>
Tue, 13 Sep 2011 20:21:10 +0000 (14:21 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 14 Sep 2011 15:56:30 +0000 (09:56 -0600)
commitf2fc1eee4cd35d0d357fa832576e698e39525a9f
treea4e0ded8bcc7d4c7d1efcfe20240ee22fa02abb8
parent72f865dd23b87e3ca13e308f8ed8e3475eb444eb
snapshot: ABI stability must include memory sizing

Commit 973fcd8f introduced the ability for qemu to reject snapshot
reversion on an ABI incompatibility; but the very example that was
first proposed on-list[1] as a demonstration of an ABI incompatibility,
namely that of changing the max memory allocation, was not being
checked for, resulting in a cryptic failure when running with larger
max mem than what the snapshot was created with:
error: operation failed: Error -22 while loading VM state

This commit merely protects the three variables within mem that are
referenced by qemu_command.c, rather than all 7 (the other 4 variables
affect cgroup handling, but as far as I can tell, have no visible effect
to the qemu guest).  This also affects migration and save file handling,
which are other places where we perform ABI compatibility checks.

[1] https://www.redhat.com/archives/libvir-list/2010-December/msg00331.html

* src/conf/domain_conf.c (virDomainDefCheckABIStability): Add
memory sizing checks.
src/conf/domain_conf.c