]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: go7007: fix a memleak in go7007_load_encoder
authorZhipeng Lu <alexious@zju.edu.cn>
Wed, 21 Feb 2024 04:37:13 +0000 (12:37 +0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:53 +0000 (18:19 -0400)
commitf31c1cc37411f5f7bcb266133f9a7e1b4bdf2975
treef8da96c8268544ca0656c0e965d4fbee24a03e2c
parent8fad9c5bb00d3a9508d18bbfe832e33a47377730
media: go7007: fix a memleak in go7007_load_encoder

[ Upstream commit b9b683844b01d171a72b9c0419a2d760d946ee12 ]

In go7007_load_encoder, bounce(i.e. go->boot_fw), is allocated without
a deallocation thereafter. After the following call chain:

saa7134_go7007_init
  |-> go7007_boot_encoder
        |-> go7007_load_encoder
  |-> kfree(go)

go is freed and thus bounce is leaked.

Fixes: 95ef39403f89 ("[media] go7007: remember boot firmware")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/go7007/go7007-driver.c