]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mailbox: Not protect module_put with spin_lock_irqsave
authorPeng Fan <peng.fan@nxp.com>
Fri, 11 Apr 2025 13:14:10 +0000 (21:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 6 Jul 2025 08:57:54 +0000 (10:57 +0200)
commitf34c4bbc0c2bd7309d979e4ce54f973005852d41
treea0b14fd8f155092261c653bed7b0484586565024
parentaaa51616993e1e276439e5286d4b556cf733e76a
mailbox: Not protect module_put with spin_lock_irqsave

[ Upstream commit dddbd233e67e792bb0a3f9694a4707e6be29b2c6 ]

&chan->lock is not supposed to protect 'chan->mbox'.
And in __mbox_bind_client, try_module_get is also not protected
by &chan->lock. So move module_put out of the lock protected
region.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mailbox/mailbox.c