]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
s390/qdio: add sanity checks to the fast-requeue path
authorJulian Wiedmann <jwi@linux.ibm.com>
Thu, 11 Jul 2019 16:17:36 +0000 (18:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Aug 2019 08:52:47 +0000 (10:52 +0200)
commitf34ef4fb5d307d211ad93b232a94c27bd5cda4af
tree1d6d1c6baa1db601ecf0eb1a5f9603a1a8a529e4
parente1c7e4efbbf873fcb9000dfd5f506a501d034cdc
s390/qdio: add sanity checks to the fast-requeue path

[ Upstream commit a6ec414a4dd529eeac5c3ea51c661daba3397108 ]

If the device driver were to send out a full queue's worth of SBALs,
current code would end up discovering the last of those SBALs as PRIMED
and erroneously skip the SIGA-w. This immediately stalls the queue.

Add a check to not attempt fast-requeue in this case. While at it also
make sure that the state of the previous SBAL was successfully extracted
before inspecting it.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/s390/cio/qdio_main.c