]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: RT bitmap and summary buffers are not typed
authorDave Chinner <dchinner@redhat.com>
Wed, 17 Feb 2016 06:08:02 +0000 (17:08 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 17 Feb 2016 06:08:02 +0000 (17:08 +1100)
commitf36349d8d346d0339f291f74a4fa2bbcab2ab700
tree9722fc59d7f90b34f95216a8f8b3c1d7edd0cc61
parent499b47f9435b90f962632dc4e472cf80e008ba84
xfs: RT bitmap and summary buffers are not typed

Source kernel commit f67ca6eca89cddd355c83639a90109e245f9d5a7

When logging buffers, we attach a type to them that follows the
buffer all the way into the log and is used to identify the buffer
contents in log recovery. Both the realtime summary buffers and the
bitmap buffers do not have types defined or set, so when we try to
log them we see assert failure:

XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 294

Fix this by adding buffer log format types for these buffers, and
add identification support into log recovery for them. Only build the log
recovery support if CONFIG_XFS_RT=y - we can't get into log recovery for real
time filesystems if support is not built into the kernel, and this avoids
potential build problems.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
libxfs/xfs_log_format.h
libxfs/xfs_rtbitmap.c