]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Handle arrays and ranges in pg_upgrade's test for non-upgradable types.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 13 Nov 2019 16:35:37 +0000 (11:35 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 13 Nov 2019 16:35:37 +0000 (11:35 -0500)
commitf378d4dac4ce80d6772ae4956cd71b10985c481c
tree3b492e30943b7df35d66382a5290e8749f599317
parent39b3a8c830097af84f655a36879eb1b686fb4cd7
Handle arrays and ranges in pg_upgrade's test for non-upgradable types.

pg_upgrade needs to check whether certain non-upgradable data types
appear anywhere on-disk in the source cluster.  It knew that it has
to check for these types being contained inside domains and composite
types; but it somehow overlooked that they could be contained in
arrays and ranges, too.  Extend the existing recursive-containment
query to handle those cases.

We probably should have noticed this oversight while working on
commit 0ccfc2822 and follow-ups, but we failed to :-(.  The whole
thing's possibly a bit overdesigned, since we don't really expect
that any of these types will appear on disk; but if we're going to
the effort of doing a recursive search then it's silly not to cover
all the possibilities.

While at it, refactor so that we have only one copy of the search
logic, not three-and-counting.  Also, to keep the branches looking
more alike, back-patch the output wording change of commit 1634d3615.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/31473.1573412838@sss.pgh.pa.us
src/bin/pg_upgrade/version.c