]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Reject concurrent sequence refreshes.
authorAmit Kapila <akapila@postgresql.org>
Wed, 15 Jul 2026 10:10:36 +0000 (15:40 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 15 Jul 2026 10:10:36 +0000 (15:40 +0530)
commitf38afa4abb04e85530c94b88daf11c089375daca
treed8389ccfda6db96fda4eab784d97c33a59cae455
parent01f78a84bf5aca4c00fe1168381830aca6f1b873
Reject concurrent sequence refreshes.

'ALTER SUBSCRIPTION ... REFRESH SEQUENCES' can race with an already
running sequence synchronization worker. If a second refresh request
resets the synchronization state while the worker has already fetched
sequence values from the publisher but has not yet applied them to the
subscriber, the worker can overwrite the subscriber with stale values
and mark the synchronization as complete.

Avoid this race by rejecting 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'
when a sequence synchronization worker is already running for the
subscription. The command reports an error asking the user to rerun it
after the current synchronization completes.

Also add a wait for the re-added 'regress_s4' sequence to finish
synchronizing in 036_sequences.pl, so the subsequent test does not race
against its sequencesync worker.

Reported-by: Noah Misch <noah@leadboat.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Shveta Malik <shveta.malik@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
src/backend/commands/subscriptioncmds.c
src/test/subscription/t/036_sequences.pl