]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Deprecate FromClause.count()
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 13 Jun 2016 19:18:13 +0000 (15:18 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 14 Jun 2016 15:48:04 +0000 (11:48 -0400)
commitf38f890849700ee1bf719a31275260e2da455bc3
treee5d8a958d853f05081e57045baa8c9806ad8f27a
parent7189d0bc82598c2d6dcbb55b054837416db2ee7d
Deprecate FromClause.count()

count() here is misleading in that it not only
counts from an arbitrary column in the table, it also
does not make accommodations for DISTINCT, JOIN, etc.
as the ORM-level function does.  Core should not be
attempting to provide a function like this.

Change-Id: I9916fc51ef744389a92c54660ab08e9695b8afc2
Fixes: #3724
21 files changed:
doc/build/changelog/changelog_10.rst
doc/build/changelog/changelog_11.rst
lib/sqlalchemy/sql/selectable.py
test/dialect/mssql/test_compiler.py
test/dialect/postgresql/test_query.py
test/engine/test_execute.py
test/orm/inheritance/test_basic.py
test/orm/inheritance/test_poly_persistence.py
test/orm/inheritance/test_polymorphic_rel.py
test/orm/inheritance/test_relationship.py
test/orm/test_association.py
test/orm/test_cascade.py
test/orm/test_dynamic.py
test/orm/test_mapper.py
test/orm/test_relationships.py
test/orm/test_transaction.py
test/orm/test_unitofwork.py
test/orm/test_unitofworkv2.py
test/sql/test_defaults.py
test/sql/test_metadata.py
test/sql/test_types.py