]> git.ipfire.org Git - thirdparty/linux.git/commit
media: nxp: imx8-isi: Simplify a couple of error messages
authorKrzysztof Hałasa <khalasa@piap.pl>
Fri, 9 May 2025 07:58:09 +0000 (09:58 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Wed, 18 Jun 2025 07:21:58 +0000 (09:21 +0200)
commitf3bc718228d0a2d102a1b20ef63b0cadbf6219f0
tree366c060978b2c56ea17de2ae94f7f0dba5be08e6
parentd06c1a9f348d22478c6bc5684f9c990e15ada1e9
media: nxp: imx8-isi: Simplify a couple of error messages

The error messages in the mxc_isi_crossbar_enable_streams() and
mxc_isi_crossbar_disable_streams() functions are similar, with a single
word difference between them. The word is moved out of the format string
to a separate dev_err() argument to try and save memory through string
de-duplication. The total savings are however small, as the .data size
reduction is partly offset by a .text size increase, with a total saving
of 8 bytes in total on an ARM64 platforms. They also come at the cost of
making the error message difficult to grep, which outweights the gains.

Simplify the error messages to make them grep-able.

Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/m3plgi9pwu.fsf@t19.piap.pl
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c