]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: midi2: Restart output URBs on resume
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Mon, 4 May 2026 14:08:45 +0000 (11:08 -0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 4 May 2026 15:49:16 +0000 (17:49 +0200)
commitf3c57c9c2a49a21d784b7c04a2c883bffc070659
tree8e36d56e54240a710c3ed689f260064d9e2a0d0d
parentdc1e0172be54e742bccb28d5f14c0c395e28c098
ALSA: usb-audio: midi2: Restart output URBs on resume

USB MIDI 2.0 suspend saves the endpoint running state, clears it and
kills all endpoint URBs. Resume restores the running state, but only
restarts input endpoints.

For a running output endpoint, this leaves the endpoint marked running
with an empty URB queue. Output transfer progress depends on either the
rawmidi trigger path starting the queue or an output completion refilling
it. After suspend there is no completion left, and output data that
remains queued in the raw UMP or legacy rawmidi buffer can stay stalled
until userspace happens to trigger the stream again.

Restore the saved state with atomic accessors, keep input endpoints
restarted as before, and restart output endpoints that were running before
suspend. Clear the saved suspend state after restoring it.

Fixes: ff49d1df79ae ("ALSA: usb-audio: USB MIDI 2.0 UMP support")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260504-usb-midi2-output-resume-v1-1-c089cc8ad3c6@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/midi2.c