]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PCI: xilinx: Fix INTx IRQ domain leak in error paths
authorHaotian Zhang <vulab@iscas.ac.cn>
Fri, 19 Dec 2025 02:16:15 +0000 (10:16 +0800)
committerManivannan Sadhasivam <mani@kernel.org>
Tue, 23 Dec 2025 12:27:47 +0000 (17:57 +0530)
commitf42b3c053b1554d66af6fe45bb1ef357464c0456
treeee800bf3c90272da07532f779689d3019edcc523
parent8f0b4cce4481fb22653697cced8d0d04027cb1e8
PCI: xilinx: Fix INTx IRQ domain leak in error paths

In xilinx_pcie_init_irq_domain(), if xilinx_allocate_msi_domains() fails
after pcie->leg_domain has been successfully created via
irq_domain_create_linear(), the function returns directly without cleaning
up the allocated IRQ domain, resulting in a resource leak. In
xilinx_free_msi_domains(), pcie->leg_domain is also neglected.

Add irq_domain_remove() call in the error path to properly release the
IRQ domain before returning the error. Also rename
xilinx_free_msi_domains() to xilinx_free_irq_domains() and add the release
of pcie->leg_domain to it.

Fixes: 313b64c3ae52 ("PCI: xilinx: Convert to MSI domains")
Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20251219021615.965-1-vulab@iscas.ac.cn
drivers/pci/controller/pcie-xilinx.c