]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
lib/bch: fix signed left-shift undefined behavior
authorJosh Law <objecting@objecting.org>
Wed, 18 Mar 2026 07:48:05 +0000 (07:48 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 28 Mar 2026 04:19:48 +0000 (21:19 -0700)
commitf42b510990030bbc0d6e4ba4486decbcd952b924
treeecbf48fbb68b9a7f1dcff8a4d2cfc731cf5312ab
parentb8822d73d6fe0d43de3b98ccc995b7032993b1b7
lib/bch: fix signed left-shift undefined behavior

Patch series "lib/bch: fix undefined behavior from signed left-shifts".

Fix two instances of undefined behavior in lib/bch.c caused by
left-shifting signed integers into or past the sign bit.

While the kernel's -fno-strict-overflow flag prevents miscompilation
today, these are formally UB per C11 6.5.7p4 and trivial to fix.

This patch (of 2):

Use 1u instead of 1 to avoid undefined behavior when left-shifting into
the sign bit of a signed int.  deg() can return up to 31, and 1 << 31 is
UB per C11.

Link: https://lkml.kernel.org/r/20260318074806.16527-2-objecting@objecting.org
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Ivan Djelic <ivan.djelic@parrot.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/bch.c