]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fpga: stratix10-soc: fix use-after-free on s10_init()
authorWen Yang <wen.yang99@zte.com.cn>
Thu, 9 May 2019 21:08:26 +0000 (16:08 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jun 2019 03:34:48 +0000 (11:34 +0800)
commitf42d43aed4d3853e1a8cd0e0230762ac5e38e5c0
tree3c4213efe6a8d16c3455a9c17ea34d995263276f
parent6ff0a7300513b526ea3bc95b4c91f8113e1a9a92
fpga: stratix10-soc: fix use-after-free on s10_init()

[ Upstream commit f5dd87326fefe42a4b1a4b1a1a695060c33a88d6 ]

The refcount of fw_np has already been decreased by of_find_matching_node()
so it shouldn't be used anymore.
This patch adds an of_node_get() before of_find_matching_node() to avoid
the use-after-free problem.

Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-fpga@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/fpga/stratix10-soc.c