]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tpm_i2c_infineon: fix potential buffer overruns caused by bit glitches on the bus
authorJeremy Boone <jeremy.boone@nccgroup.trust>
Thu, 8 Feb 2018 20:30:01 +0000 (12:30 -0800)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 21 Mar 2018 03:49:46 +0000 (23:49 -0400)
commitf49123e361fd503b6bdfc6c512259a7103d61d1c
tree1395e7331a46dbf18344944e9ac5cbb912780cb0
parent5e0b41c73710f26884619f97843fa395edcdf7a3
tpm_i2c_infineon: fix potential buffer overruns caused by bit glitches on the bus

[ Upstream commit 9b8cb28d7c62568a5916bdd7ea1c9176d7f8f2ed ]

Discrete TPMs are often connected over slow serial buses which, on
some platforms, can have glitches causing bit flips.  In all the
driver _recv() functions, we need to use a u32 to unmarshal the
response size, otherwise a bit flip of the 31st bit would cause the
expected variable to go negative, which would then try to read a huge
amount of data.  Also sanity check that the expected amount of data is
large enough for the TPM header.

Signed-off-by: Jeremy Boone <jeremy.boone@nccgroup.trust>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/char/tpm/tpm_i2c_infineon.c