]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
do_generic_file_read: clear page errors when issuing a fresh read of the page
authorJeff Moyer <jmoyer@redhat.com>
Wed, 26 May 2010 15:49:40 +0000 (11:49 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:22:39 +0000 (11:22 -0700)
commitf49f5fa23366903b7a2c92545db3ee629958778f
tree39282d648d3e6ef4ce1cc9737878e61594589b19
parentfa31d3fc1debc200bf66240519e77aac606d40fa
do_generic_file_read: clear page errors when issuing a fresh read of the page

commit 91803b499cca2fe558abad709ce83dc896b80950 upstream.

I/O errors can happen due to temporary failures, like multipath
errors or losing network contact with the iSCSI server. Because
of that, the VM will retry readpage on the page.

However, do_generic_file_read does not clear PG_error.  This
causes the system to be unable to actually use the data in the
page cache page, even if the subsequent readpage completes
successfully!

The function filemap_fault has had a ClearPageError before
readpage forever.  This patch simply adds the same to
do_generic_file_read.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Rik van Riel <riel@redhat.com>
Acked-by: Larry Woodman <lwoodman@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mm/filemap.c