]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ses: Fix problems with simple enclosures
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 8 Dec 2015 17:00:31 +0000 (09:00 -0800)
committerWilly Tarreau <w@1wt.eu>
Fri, 29 Jan 2016 21:12:51 +0000 (22:12 +0100)
commitf49fbe9ebc13e57ba5b2d91a1c1ffe0b4edf0cb1
treefdbb9759b6eabe117651374c67f473ba642d36a1
parent8a90c7575b8103e48f5d9daa1557d319148fb445
ses: Fix problems with simple enclosures

commit 3417c1b5cb1fdc10261dbed42b05cc93166a78fd upstream.

Simple enclosure implementations (mostly USB) are allowed to return only
page 8 to every diagnostic query.  That really confuses our
implementation because we assume the return is the page we asked for and
end up doing incorrect offsets based on bogus information leading to
accesses outside of allocated ranges.  Fix that by checking the page
code of the return and giving an error if it isn't the one we asked for.
This should fix reported bugs with USB storage by simply refusing to
attach to enclosures that behave like this.  It's also good defensive
practise now that we're starting to see more USB enclosures.

Reported-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit 25ef938516d26c3db9cb1f5b927ad7ee95be1022)
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/scsi/ses.c