]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/dp_mst: Verify request type in the corresponding down message reply
authorImre Deak <imre.deak@intel.com>
Tue, 3 Dec 2024 16:02:18 +0000 (18:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:28 +0000 (20:03 +0100)
commitf4e1544ab82ca7120cd7aad34267b57b43c1bed4
treec17d28c0fc74c267f460973baa400b2b46604b04
parent0a203ff705fd98ee6f9b2925fe50a3c362cce88e
drm/dp_mst: Verify request type in the corresponding down message reply

commit 4d49e77a973d3b5d1881663c3f122906a0702940 upstream.

After receiving the response for an MST down request message, the
response should be accepted/parsed only if the response type matches
that of the request. Ensure this by checking if the request type code
stored both in the request and the reply match, dropping the reply in
case of a mismatch.

This fixes the topology detection for an MST hub, as described in the
Closes link below, where the hub sends an incorrect reply message after
a CLEAR_PAYLOAD_TABLE -> LINK_ADDRESS down request message sequence.

Cc: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org>
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12804
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241203160223.2926014-3-imre.deak@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/display/drm_dp_mst_topology.c