]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: fail on attempts to use <filterref> for non-tap network connections
authorLaine Stump <laine@laine.org>
Mon, 10 Aug 2015 06:05:29 +0000 (02:05 -0400)
committerLaine Stump <laine@laine.org>
Mon, 10 Aug 2015 17:08:41 +0000 (13:08 -0400)
commitf4f1d18dc464a4fd436ce9cdd18d6f06fa7494e5
tree66261f3ca207687a4f46db41696f05461b2270b3
parenta6f9af8292b6462e509892b3a16acbcaaef61e4e
qemu: fail on attempts to use <filterref> for non-tap network connections

nwfilter uses iptables and ebtables, which only work properly on
tap-based network connections (*not* on macvtap, for example), but we
just ignore any <filterref> elements for other types of networks,
potentially giving users a false sense of security.

This patch checks the network type and fails/logs an error if any
domain <interface> has a <filterref> when the connection isn't using a
tap device.

This resolves:

  https://bugzilla.redhat.com/show_bug.cgi?id=1180011
src/qemu/qemu_command.c
src/qemu/qemu_hotplug.c