]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: fix leaf leak in an error path in btrfs_del_items()
authorFilipe Manana <fdmanana@suse.com>
Thu, 13 Nov 2025 12:52:45 +0000 (12:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:03:16 +0000 (14:03 +0100)
commitf5190da518bed09b1f82dec89cdf931a177243f3
tree3fe10977ec7b432249dc9a4dd6651d6bb895905d
parentd65f49f772cf51ea0fedacf96ae2b906876ea73c
btrfs: fix leaf leak in an error path in btrfs_del_items()

[ Upstream commit e7dd1182fcedee7c6097c9f49eba8de94a4364e3 ]

If the call to btrfs_del_leaf() fails we return without decrementing the
extra ref we took on the leaf, therefore leaking it. Fix this by ensuring
we drop the ref count before returning the error.

Fixes: 751a27615dda ("btrfs: do not BUG_ON() on tree mod log failures at btrfs_del_ptr()")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/ctree.c