]> git.ipfire.org Git - thirdparty/zstd.git/commit
projects / thirdparty / zstd.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c0eb6c9) | patch
Remove ZSTD_DLL_EXPORT=1 for static lib 1650/head
authorSai Charan Koduru <me@saicharan.in>
Wed, 12 Jun 2019 19:26:36 +0000 (12:26 -0700)
committerSai Charan Koduru <me@saicharan.in>
Wed, 12 Jun 2019 19:26:36 +0000 (12:26 -0700)
commitf547dca9e3155308af4cffee47f380b763623e81
tree44036d9cd7cbcc537a6a103643d94e95438f0ae9tree
parentc0eb6c9c81e2dd31571267b37c12cdaa92b7ffd7commit | diff
Remove ZSTD_DLL_EXPORT=1 for static lib

As a principle, static libs should not dllexport methods, that should only be used when building DLLs.

Case in point: when static libs with dllexport directives are linked into DLLs created with a .def file, the VC++ compiler exports the dllexported methods into the DLL, in addition to the exports listed in the .def file. This will result in undesired link dependencies and is not the correct thing to do.
build/VS2010/libzstd/libzstd.vcxproj diff | blob | blame | history
Mirror of https://github.com/facebook/zstd.git