]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rpmsg: glink: Propagate TX failures in intentless mode as well
authorBjorn Andersson <quic_bjorande@quicinc.com>
Tue, 18 Apr 2023 16:30:17 +0000 (09:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:19 +0000 (19:51 +0100)
commitf5872a2a84ec889d0a8f264d3ed0936670860479
tree8ba51a7c8eeb62a550872ed1fc4af2ffa43d0e10
parentc7dac3af57e38b2054f990e573256d90bf887958
rpmsg: glink: Propagate TX failures in intentless mode as well

commit 7a68f9fa97357a0f2073c9c31ed4101da4fce93e upstream.

As support for splitting transmission over several messages using
TX_DATA_CONT was introduced it does not immediately return the return
value of qcom_glink_tx().

The result is that in the intentless case (i.e. intent == NULL), the
code will continue to send all additional chunks. This is wasteful, and
it's possible that the send operation could incorrectly indicate
success, if the last chunk fits in the TX fifo.

Fix the condition.

Fixes: 8956927faed3 ("rpmsg: glink: Add TX_DATA_CONT command while sending")
Reviewed-by: Chris Lew <quic_clew@quicinc.com>
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230418163018.785524-2-quic_bjorande@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rpmsg/qcom_glink_native.c