]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: imx: Fix UAF on package-1 prepare failure in spi_imx_dma_data_prepare()
authorJohn Madieu <john.madieu@gmail.com>
Fri, 1 May 2026 13:59:50 +0000 (13:59 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 4 May 2026 13:22:15 +0000 (22:22 +0900)
commitf5b5548255040ec3bef05bcb1e9c9c3614dfa7db
tree123572835cf4f3800cbffd45f55882e80fff0da7
parent24e0fd8b852062d5e8a740f7945eaa26818adce8
spi: imx: Fix UAF on package-1 prepare failure in spi_imx_dma_data_prepare()

When transfer->len exceeds MX51_ECSPI_CTRL_MAX_BURST and is not a
multiple of it, spi_imx_dma_data_prepare() splits the transfer into
two DMA packages. If preparing the second package fails:

ret = spi_imx_dma_tx_data_handle(spi_imx, &spi_imx->dma_data[1],
 transfer->tx_buf + spi_imx->dma_data[0].data_len,
 false);
if (ret) {
kfree(spi_imx->dma_data[0].dma_tx_buf);
kfree(spi_imx->dma_data[0].dma_rx_buf);
kfree(spi_imx->dma_data);
}
}

return 0;

the function frees the package-0 buffers and the dma_data array,
then falls through to `return 0`, telling the caller the prepare
succeeded. The caller then dereferences the freed dma_data array,
producing a use-after-free.

Return the error from the failure path so the caller takes its
existing failure branch.

Fixes: faa8e404ad8e ("spi: imx: support dynamic burst length for ECSPI DMA mode")
Signed-off-by: John Madieu <john.madieu@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260501135951.2416527-3-john.madieu@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c