]> git.ipfire.org Git - thirdparty/coreutils.git/commit
runcon: revert "disable use of the TIOCSTI ioctl"
authorPádraig Brady <P@draigBrady.com>
Wed, 30 Aug 2017 07:27:41 +0000 (00:27 -0700)
committerPádraig Brady <P@draigBrady.com>
Wed, 30 Aug 2017 07:28:20 +0000 (00:28 -0700)
commitf5d7c0842ef7adc2be6e85f9ef66b35ebbbd6a61
tree3ce94608a0f58400eb86bce1abeab2be8300e322
parentf169345506ac5a095cd100d016c84dc44b33e851
runcon: revert "disable use of the TIOCSTI ioctl"

This reverts commit v8.27-97-g8cb06d4 because
the setsid() fallback was not implemented correctly
and disabling the ioctl was not a complete solution
to the security issue of the child being passed
the tty of the parent.

Given runcon is not really a sandbox command,
the advice is to use `runcon ... setsid ...`
to avoid this particular issue.
NEWS
m4/jm-macros.m4
src/local.mk
src/runcon.c
tests/local.mk
tests/misc/runcon-no-inject.sh [deleted file]