]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix yet another portability problem in new NLS test.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Jul 2026 22:08:23 +0000 (18:08 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Jul 2026 22:08:23 +0000 (18:08 -0400)
commitf5dfd52553d3b041e30e9b1f1c6eb9f7af55fbdb
treeb826b8f3d84ce1d6849b7f70d9012beaca085fdb
parent4dbc54506c328a03070bf1a98309bdc05dac331d
Fix yet another portability problem in new NLS test.

Álvaro reported offlist that his machine was passing the new-in-v19
nls.sql test in "make check" but not in "make installcheck".  On
investigation, the cause turned out to be that he has LANGUAGE set in
his environment, and with (at least recent versions of) glibc that
overrides LC_MESSAGES and friends, as per previous research by Bryan
Green.  "make check" works because pg_regress unsets LANGUAGE before
starting the postmaster, but in installcheck mode we're exposed to
the prevailing value and we lose.

We're already hacking the value of LANGUAGE in this test for Solaris,
so let's just extend that to unsetting LANGUAGE on every other platform.

Reported-by: Álvaro Herrera <alvherre@kurilemu.de>
Diagnosed-by: Andrew Dunstan <andrew@dunslane.net>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/a337896e-5bff-490b-afc9-c545f06c014c@gmail.com
Backpatch-through: 19
src/test/regress/regress.c