]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kernel/module: Fix memleak in module_add_modinfo_attrs()
authorYueHaibing <yuehaibing@huawei.com>
Sat, 28 Dec 2019 11:54:55 +0000 (19:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:26 +0000 (08:36 +0100)
commitf606721660a614470869cab35317ff880b46283b
treece06748995729b4470b6064fb67094a49c1824fa
parentfc3c0fc85d69ece2eee38f617384e22ce3191250
kernel/module: Fix memleak in module_add_modinfo_attrs()

[ Upstream commit f6d061d617124abbd55396a3bc37b9bf7d33233c ]

In module_add_modinfo_attrs() if sysfs_create_file() fails
on the first iteration of the loop (so i = 0), we forget to
free the modinfo_attrs.

Fixes: bc6f2a757d52 ("kernel/module: Fix mem leak in module_add_modinfo_attrs")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/module.c