]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ftrace/x86_32: Set ftrace_stub to weak to prevent gcc from using short jumps to it
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Thu, 8 Dec 2016 17:48:26 +0000 (12:48 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Jan 2017 07:21:57 +0000 (08:21 +0100)
commitf61152e3bbf0bc1a3a2f0bd635835e0bb90ced7a
treef0782ba50bad1e198c0a668bd043554283dd9619
parent8569aadeed3fe07befec67127acaecc58eca1a5f
ftrace/x86_32: Set ftrace_stub to weak to prevent gcc from using short jumps to it

commit 847fa1a6d3d00f3bdf68ef5fa4a786f644a0dd67 upstream.

With new binutils, gcc may get smart with its optimization and change a jmp
from a 5 byte jump to a 2 byte one even though it was jumping to a global
function. But that global function existed within a 2 byte radius, and gcc
was able to optimize it. Unfortunately, that jump was also being modified
when function graph tracing begins. Since ftrace expected that jump to be 5
bytes, but it was only two, it overwrote code after the jump, causing a
crash.

This was fixed for x86_64 with commit 8329e818f149, with the same subject as
this commit, but nothing was done for x86_32.

Fixes: d61f82d06672 ("ftrace: use dynamic patching for updating mcount calls")
Reported-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/entry/entry_32.S