]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpio: tc35894: fix up tc35894 interrupt configuration
authordillon min <dillon.minfei@gmail.com>
Thu, 3 Sep 2020 07:30:21 +0000 (15:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Oct 2020 06:02:45 +0000 (08:02 +0200)
commitf67837215194d2d7b82400470255254f70f48f98
tree00b04d4c3a6bbd3ab08e7ced28d6b4c59e2692ff
parentbaeac67ee6e29f2202eaddbec8dc23d78a8447d9
gpio: tc35894: fix up tc35894 interrupt configuration

commit 214b0e1ad01abf4c1f6d8d28fa096bf167e47cef upstream.

The offset of regmap is incorrect, j * 8 is move to the
wrong register.

for example:

asume i = 0, j = 1. we want to set KPY5 as interrupt
falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd
but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4,
this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1.

Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver")
Cc: Cc: stable@vger.kernel.org
Signed-off-by: dillon min <dillon.minfei@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpio-tc3589x.c