]> git.ipfire.org Git - thirdparty/linux.git/commit
phy: renesas: rcar-gen3-usb2: Simplify ID/VBUS detection logic
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Wed, 25 Mar 2026 11:20:39 +0000 (11:20 +0000)
committerVinod Koul <vkoul@kernel.org>
Sun, 3 May 2026 17:05:57 +0000 (22:35 +0530)
commitf67ab4706ab72af29c331b21f431c463b00d447a
treeeec77eda13390d936a58119d5d00da01bbdcc84a
parent0bd448b5467b7ead268bc3a946c1deabbda70fe0
phy: renesas: rcar-gen3-usb2: Simplify ID/VBUS detection logic

Read USB2_ADPCTRL once in rcar_gen3_check_id() instead of issuing
multiple MMIO reads, and derive both IDDIG and VBUSVALID from the same
value.

Drop the redundant !! operator, as assigning a masked u32 value to a
bool already performs the required normalization. Simplify the logic by
comparing the ID and VBUS status directly, which is equivalent to the
previous conditional but easier to follow.

Reported-by: Pavel Machek <pavel@nabladev.com>
Closes: https://lore.kernel.org/all/acJVCOdlchLiSe5n@duo.ucw.cz/
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/20260325112039.464992-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/renesas/phy-rcar-gen3-usb2.c