]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda - Fix broken PM due to incomplete i915 initialization
authorTakashi Iwai <tiwai@suse.de>
Tue, 15 Jul 2014 13:19:43 +0000 (15:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Jul 2014 15:08:19 +0000 (08:08 -0700)
commitf742278cdd7afa342898e18ad17ab2accf81c57e
treee1f7f21ef6ecbf5c582dff1d9ace052f2ea9db75
parentbf2ed225999e6e8d2a7e2e3a5c938df1d5077b03
ALSA: hda - Fix broken PM due to incomplete i915 initialization

commit 4da63c6fc426023d1a20e45508c47d7d68c6a53d upstream.

When the initialization of Intel HDMI controller fails due to missing
i915 kernel symbols (e.g. HD-audio is built in while i915 is module),
the driver discontinues the probe.  However, since the probe was done
asynchronously, the driver object still remains, thus the relevant PM
ops are still called at suspend/resume. This results in the bad access
to the incomplete audio card object, eventually leads to Oops or stall
at PM.

This patch adds the missing checks of chip->init_failed flag at each
PM callback in order to fix the problem above.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79561
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/hda_intel.c