]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
lib: string_helpers: silence snprintf() output truncation warning
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 1 Nov 2024 20:54:53 +0000 (21:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:18 +0000 (19:51 +0100)
commitf78318f70e3c5510179f4247c877ff9f57eb8bc4
treeb8978bfdf0b721c6557ae54f6ca683c3227cef5e
parent0247da93bf62d33304b7bf97850ebf2a86e06d28
lib: string_helpers: silence snprintf() output truncation warning

commit a508ef4b1dcc82227edc594ffae583874dd425d7 upstream.

The output of ".%03u" with the unsigned int in range [0, 4294966295] may
get truncated if the target buffer is not 12 bytes. This can't really
happen here as the 'remainder' variable cannot exceed 999 but the
compiler doesn't know it. To make it happy just increase the buffer to
where the warning goes away.

Fixes: 3c9f3681d0b4 ("[SCSI] lib: add generic helper to print sizes rounded to the correct SI range")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kees Cook <kees@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://lore.kernel.org/r/20241101205453.9353-1-brgl@bgdev.pl
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/string_helpers.c