]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: 8250: fix return error code in serial8250_request_std_resource()
authorYi Yang <yiyang13@huawei.com>
Tue, 28 Jun 2022 08:35:15 +0000 (16:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 18:40:33 +0000 (20:40 +0200)
commitf7a4aabcb3aced96d7ae4c82222b9739bb979a74
treefa87c6ecf0563cde61a4b0ecbde27d29573ed795
parentb0b882a42380bd4e55e16c618823c97fbd750c40
serial: 8250: fix return error code in serial8250_request_std_resource()

commit 6e690d54cfa802f939cefbd2fa2c91bd0b8bd1b6 upstream.

If port->mapbase = NULL in serial8250_request_std_resource() , it need
return a error code instead of 0. If uart_set_info() fail to request new
regions by serial8250_request_std_resource() but the return value of
serial8250_request_std_resource() is 0, The system incorrectly considers
that the resource application is successful and does not attempt to
restore the old setting. A null pointer reference is triggered when the
port resource is later invoked.

Signed-off-by: Yi Yang <yiyang13@huawei.com>
Cc: stable <stable@kernel.org>
Link: https://lore.kernel.org/r/20220628083515.64138-1-yiyang13@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c