]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tty: rp2: Fix reset with non forgiving PCIe host bridges
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Fri, 6 Sep 2024 22:54:33 +0000 (15:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:51 +0000 (16:29 +0200)
commitf7ba350f4e7d5020ae1767d71705e61dae6700bc
treeaee7d65c920ea7bae1108d505c1bc2b29888f5a9
parent7420c1bf7fc784e587b87329cc6dfa3dca537aa4
tty: rp2: Fix reset with non forgiving PCIe host bridges

commit f16dd10ba342c429b1e36ada545fb36d4d1f0e63 upstream.

The write to RP2_GLOBAL_CMD followed by an immediate read of
RP2_GLOBAL_CMD in rp2_reset_asic() is intented to flush out the write,
however by then the device is already in reset and cannot respond to a
memory cycle access.

On platforms such as the Raspberry Pi 4 and others using the
pcie-brcmstb.c driver, any memory access to a device that cannot respond
is met with a fatal system error, rather than being substituted with all
1s as is usually the case on PC platforms.

Swapping the delay and the read ensures that the device has finished
resetting before we attempt to read from it.

Fixes: 7d9f49afa451 ("serial: rp2: New driver for Comtrol RocketPort 2 cards")
Cc: stable <stable@kernel.org>
Suggested-by: Jim Quinlan <james.quinlan@broadcom.com>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20240906225435.707837-1-florian.fainelli@broadcom.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/rp2.c