]> git.ipfire.org Git - thirdparty/linux.git/commit
tipc: fix null-ptr-deref when acquiring remote ip of ethernet bearer
authorHaixia Qu <hxqu@hillstonenet.com>
Tue, 17 Jun 2025 05:56:24 +0000 (05:56 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jun 2025 21:19:50 +0000 (14:19 -0700)
commitf82727adcf2992822e12198792af450a76ebd5ef
treefe08c8756aae18bc1f0820f15e595f95c43458fc
parent9ac8d0c640a161486eaf71d1999ee990fad62947
tipc: fix null-ptr-deref when acquiring remote ip of ethernet bearer

The reproduction steps:
1. create a tun interface
2. enable l2 bearer
3. TIPC_NL_UDP_GET_REMOTEIP with media name set to tun

tipc: Started in network mode
tipc: Node identity 8af312d38a21, cluster identity 4711
tipc: Enabled bearer <eth:syz_tun>, priority 1
Oops: general protection fault
KASAN: null-ptr-deref in range
CPU: 1 UID: 1000 PID: 559 Comm: poc Not tainted 6.16.0-rc1+ #117 PREEMPT
Hardware name: QEMU Ubuntu 24.04 PC
RIP: 0010:tipc_udp_nl_dump_remoteip+0x4a4/0x8f0

the ub was in fact a struct dev.

when bid != 0 && skip_cnt != 0, bearer_list[bid] may be NULL or
other media when other thread changes it.

fix this by checking media_id.

Fixes: 832629ca5c313 ("tipc: add UDP remoteip dump to netlink API")
Signed-off-by: Haixia Qu <hxqu@hillstonenet.com>
Reviewed-by: Tung Nguyen <tung.quang.nguyen@est.tech>
Link: https://patch.msgid.link/20250617055624.2680-1-hxqu@hillstonenet.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/udp_media.c