]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Don't do recovery operations under Empty/AttributeError
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 14 Jul 2017 22:06:48 +0000 (18:06 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 25 Aug 2017 20:12:30 +0000 (16:12 -0400)
commitf87069a3b0e9c2d79eced81a0326a9a904106dc6
tree6a5fb58ff0c92af3c3ebcd0af9c5c954fde43864
parent887fb3ebaad20847edc752f5fcf072ace947d56a
Don't do recovery operations under Empty/AttributeError

Made some adjustments to :class:`.Pool` and :class:`.Connection` such
that recovery logic is not run underneath exception catches for
``pool.Empty``, ``AttributeError``, since when the recovery operation
itself fails, Python 3 creates a misleading stack trace referring to the
``Empty`` / ``AttributeError`` as the cause, when in fact these exception
catches are part of control flow.

Change-Id: Id3ed9a8f96ce4ccb4009c94af30ddc2ddb9818b9
Fixes: #4028
doc/build/changelog/unreleased_12/4028.rst [new file with mode: 0644]
lib/sqlalchemy/engine/base.py
lib/sqlalchemy/pool.py