]> git.ipfire.org Git - thirdparty/linux.git/commit
virtio-net: enable NETIF_F_GRO_HW only if GRO-related offloads are supported
authorDi Zhu <zhud@hygon.cn>
Mon, 23 Mar 2026 04:17:30 +0000 (12:17 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 Mar 2026 03:28:49 +0000 (20:28 -0700)
commitf8844dfeeae88db074146e3f8a865b5565f61b40
tree9a3b1d9d85b8db0440f2164919ded41eed4be65a
parent6a539eee855cbfe9c32507c70003b7710604fcfb
virtio-net: enable NETIF_F_GRO_HW only if GRO-related offloads are supported

Negotiating VIRTIO_NET_F_CTRL_GUEST_OFFLOADS indicates the device
allows control over offload support, but the offloads that can be
controlled may have nothing to do with GRO (e.g., if neither GUEST_TSO4
nor GUEST_TSO6 is supported).

In such a setup, reporting NETIF_F_GRO_HW as available for the device
is too optimistic and misleading to the user.

Improve the situation by masking off NETIF_F_GRO_HW unless the device
possesses actual GRO-related offload capabilities. Out of an abundance
of caution, this does not change the current behaviour for hardware with
just v6 or just v4 GRO: current interfaces do not allow distinguishing
between v6/v4 GRO, so we can't expose them to userspace precisely.

Signed-off-by: Di Zhu <zhud@hygon.cn>
Acked-by: Jason Wang <jasowang@redhat.com>
Link: https://patch.msgid.link/20260323041730.986351-1-zhud@hygon.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/virtio_net.c