]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: tc358743: Fix error return code in tc358743_probe_of()
authorZhen Lei <thunder.leizhen@huawei.com>
Sat, 15 May 2021 06:58:30 +0000 (08:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:15:47 +0000 (16:15 +0200)
commitf8985454809f165a29961c434bb523bbf110acb3
tree2c19a00d4aee346e5e2d4fb03a9b8b3683b5fb17
parentb334329a212ffd9dee8429d2bef2fcfc8d701f9d
media: tc358743: Fix error return code in tc358743_probe_of()

[ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ]

When the CSI bps per lane is not in the valid range, an appropriate error
code -EINVAL should be returned. However, we currently do not explicitly
assign this error code to 'ret'. As a result, 0 was incorrectly returned.

Fixes: 256148246852 ("[media] tc358743: support probe from device tree")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/tc358743.c