]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ARM: 9071/1: uprobes: Don't hook on thumb instructions
authorFredrik Strupe <fredrik@strupe.net>
Mon, 5 Apr 2021 20:52:05 +0000 (21:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Apr 2021 10:05:47 +0000 (12:05 +0200)
commitf8e8371cf767264ed16bcd6c6fe150d842ce52c7
tree094ffb60ade5f70fcfbf2dabdab23a3bda6f72e5
parent18045accd5388354dc9083fb2b26220c959c7314
ARM: 9071/1: uprobes: Don't hook on thumb instructions

commit d2f7eca60b29006285d57c7035539e33300e89e5 upstream.

Since uprobes is not supported for thumb, check that the thumb bit is
not set when matching the uprobes instruction hooks.

The Arm UDF instructions used for uprobes triggering
(UPROBE_SWBP_ARM_INSN and UPROBE_SS_ARM_INSN) coincidentally share the
same encoding as a pair of unallocated 32-bit thumb instructions (not
UDF) when the condition code is 0b1111 (0xf). This in effect makes it
possible to trigger the uprobes functionality from thumb, and at that
using two unallocated instructions which are not permanently undefined.

Signed-off-by: Fredrik Strupe <fredrik@strupe.net>
Cc: stable@vger.kernel.org
Fixes: c7edc9e326d5 ("ARM: add uprobes support")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/probes/uprobes/core.c