]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "nvmet-tcp: Don't free SQ on authentication success"
authorAlistair Francis <alistair.francis@wdc.com>
Fri, 17 Apr 2026 00:48:08 +0000 (10:48 +1000)
committerKeith Busch <kbusch@kernel.org>
Wed, 22 Apr 2026 17:07:30 +0000 (10:07 -0700)
commitf920ebd03cd13eb0976d18de77adf325b5461361
tree9a967c4fb2c190941371ad8dbfccf9bf7b976b1b
parentbddb911d28d4412a9462e73766a706ff0d74fa77
Revert "nvmet-tcp: Don't free SQ on authentication success"

In an attempt to fix REPLACETLSPSK we stopped freeing the secrets on
successful connections. This resulted in memory leaks in the kernel, so
let's revert the commit. A improved fix is being developed to just avoid
clearing the tls_key variable.

This reverts commit 2e6eb6b277f593b98f151ea8eff1beb558bbea3b.

Closes: https://lore.kernel.org/linux-nvme/CAHj4cs-u3MWQR4idywptMfjEYi4YwObWFx4KVib35dZ5HMBDdw@mail.gmail.com
Reviewed-by: Chris Leech <cleech@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/fabrics-cmd-auth.c