]> git.ipfire.org Git - thirdparty/linux.git/commit
net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback
authorKery Qi <qikeyu2017@gmail.com>
Thu, 8 Jan 2026 16:42:57 +0000 (00:42 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 12 Jan 2026 17:04:52 +0000 (09:04 -0800)
commitf93fc5d12d69012788f82151bee55fce937e1432
treeffb384338eee796c9de21d6adedf23b5e2d37b7a
parent16ce6e6fa946ca6fd1e4fce6926b52b6263d98a8
net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback

octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
ioq_vector. If request_irq() fails part-way, the rollback loop calls
free_irq() with dev_id set to 'oct', which does not match the original
dev_id and may leave the irqaction registered.

This can keep IRQ handlers alive while ioq_vector is later freed during
unwind/teardown, leading to a use-after-free or crash when an interrupt
fires.

Fix the error path to free IRQs with the same ioq_vector dev_id used
during request_irq().

Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Link: https://patch.msgid.link/20260108164256.1749-2-qikeyu2017@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c