]> git.ipfire.org Git - thirdparty/asterisk.git/commit
Locking order in app_queue.c causes deadlocks.
authorGregory Nietsky <gregory@distrotech.co.za>
Thu, 15 Sep 2011 15:46:21 +0000 (15:46 +0000)
committerGregory Nietsky <gregory@distrotech.co.za>
Thu, 15 Sep 2011 15:46:21 +0000 (15:46 +0000)
commitf94fa3dba396143df41f611656402a3d48d68806
tree86a57e37c3bcdae787f3967e6943b3afc7394b03
parent46e29689170a78c2450190d544acde759fada780
Locking order in app_queue.c causes deadlocks.

a channel lock must never be held with the queues container lock held.

the deadlock occured on masquerade.

the queues container lock is a relic of the past the old queue module lock.
with ao2 there is no need to hold this lock when dealing with members this
patch removes unneeded locks.

(closes issue ASTERISK-18101)
(closes issue ASTERISK-18487)
Reported by: Paul Rolfe, Jason Legault
Tested by: irroot, Jason Legault, Paul Rolfe
Reviewed by: Matthew Nicholson

Review: https://reviewboard.asterisk.org/r/1402/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@336093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
apps/app_queue.c