]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Don't copy memory for arguments if there are none
authorHannes Domani <ssbssa@yahoo.de>
Sun, 27 Oct 2024 18:30:38 +0000 (19:30 +0100)
committerHannes Domani <ssbssa@yahoo.de>
Mon, 28 Oct 2024 20:00:12 +0000 (21:00 +0100)
commitf951f2dbb8f57fa6469a6935116a31004c7e373a
treeef6728c836c0c0002bb89b8b7b7c29c626327161
parent2930265f05600c1fd1ecdf2eb0889d977079ef78
Don't copy memory for arguments if there are none

If amd64_windows_push_arguments is called with no arguments, then ARGS
can be NULL, and inside the passed-by-pointer block, memcpy is called
with this NULL, which is undefined behavior.

So this just disable the passed-by-pointer block if there are no
arguments.

Fixes the following ubsan error:
C:/gdb/src/gdb.git/gdb/amd64-windows-tdep.c:244:12: runtime error: null pointer passed as argument 2, which is declared to never be null

Approved-By: Tom Tromey <tom@tromey.com>
gdb/amd64-windows-tdep.c