]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kcm: do not attach PF_KCM sockets to avoid deadlock
authorEric Dumazet <edumazet@google.com>
Wed, 30 Aug 2017 16:29:31 +0000 (09:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Sep 2017 06:22:08 +0000 (08:22 +0200)
commitf9901adf536c8430f29bddb36cc648e02143b8ec
tree2366d3231910d91eb70db3d873b40854ab4b6f47
parente7ebdeb47c8b14614c65a0a2ad07cf4c04e51469
kcm: do not attach PF_KCM sockets to avoid deadlock

[ Upstream commit 351050ecd6523374b370341cc29fe61e2201556b ]

syzkaller had no problem to trigger a deadlock, attaching a KCM socket
to another one (or itself). (original syzkaller report was a very
confusing lockdep splat during a sendmsg())

It seems KCM claims to only support TCP, but no enforcement is done,
so we might need to add additional checks.

Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Acked-by: Tom Herbert <tom@quantonium.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/kcm/kcmsock.c