]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ntfs3: work around false-postive -Wmaybe-uninitialized warnings
authorArnd Bergmann <arnd@arndb.de>
Thu, 12 Mar 2026 16:49:33 +0000 (17:49 +0100)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Tue, 24 Mar 2026 17:51:28 +0000 (18:51 +0100)
commitf9963deaa891479da24e32fc614c08f158fe1608
treebe0442931ff2a54885110779f04f8a6871084285
parentd7ea8495fd307b58f8867acd81a1b40075b1d3ba
ntfs3: work around false-postive -Wmaybe-uninitialized warnings

gcc sometimes fails to analyse how two local variables in ntfs_write_bh()
are initialized, as the initialization happens only in the first pass
through the main loop:

fs/ntfs3/fsntfs.c: In function 'ntfs_write_bh':
fs/ntfs3/fsntfs.c:1443:17: error: 'fixup' may be used uninitialized [-Werror=maybe-uninitialized]
 1443 |         __le16 *fixup;
      |                 ^~~~~
fs/ntfs3/fsntfs.c:1443:17: note: 'fixup' was declared here
 1443 |         __le16 *fixup;
      |                 ^~~~~
fs/ntfs3/fsntfs.c:1487:30: error: 'sample' may be used uninitialized [-Werror=maybe-uninitialized]
 1487 |                         *ptr = sample;
      |                         ~~~~~^~~~~~~~
fs/ntfs3/fsntfs.c:1444:16: note: 'sample' was declared here
 1444 |         __le16 sample;

Initializing the two variables to bogus values shuts up the warning and
makes it clear that those cannot be used. I tried rearranging the loop to
move the initialization in front of it, but couldn't quite figure it out.

Fixes: 48d9b57b169f ("fs/ntfs3: add a subset of W=1 warnings for stricter checks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/fsntfs.c