]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv6: fix possible UAF in icmpv6_rcv()
authorEric Dumazet <edumazet@google.com>
Thu, 16 Apr 2026 10:35:05 +0000 (10:35 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 18 Apr 2026 19:09:52 +0000 (12:09 -0700)
commitf996edd7615e686ada141b7f3395025729ff8ccb
tree48af59f58fda2d1a860a61652adac064766b7903
parentdcf6d5e629db8f85bdea5c6c102f5bfd4b05bf44
ipv6: fix possible UAF in icmpv6_rcv()

Caching saddr and daddr before pskb_pull() is problematic
since skb->head can change.

Remove these temporary variables:

- We only access &ipv6_hdr(skb)->saddr and &ipv6_hdr(skb)->daddr
  when net_dbg_ratelimited() is called in the slow path.

- Avoid potential future misuse after pskb_pull() call.

Fixes: 4b3418fba0fe ("ipv6: icmp: include addresses in debug messages")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Reviewed-by: Joe Damato <joe@dama.to>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260416103505.2380753-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/icmp.c